Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Invalid date on folders #410

Closed
wraithy opened this issue May 18, 2023 · 24 comments · Fixed by #441
Closed

Bug: Invalid date on folders #410

wraithy opened this issue May 18, 2023 · 24 comments · Fixed by #441
Labels
bug Something isn't working

Comments

@wraithy
Copy link

wraithy commented May 18, 2023

What happened?

The "creation date" and "last updated" dates show as "invalid date" on the list view and "NaN years ago" in the grid view.

List View

image

Grid View

image

Version

upstream (ghcr.io/diced/zipline:trunk)

What browser(s) are you seeing the problem on?

No response

Zipline Logs

No response

Browser Logs

No response

Additional Info

No response

@wraithy wraithy added the bug Something isn't working label May 18, 2023
@github-actions github-actions bot added this to the 3.7.1 milestone May 18, 2023
@TacticalTechJay
Copy link
Collaborator

Try ghcr.io/diced/zipline:trunk for the docker image if you're using ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest. It may already be fixed in the recommended image.

@wraithy
Copy link
Author

wraithy commented May 19, 2023

Try ghcr.io/diced/zipline:trunk for the docker image if you're using ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest. It may already be fixed in the recommended image.

I switched my docker image to ghcr.io/diced/zipline:trunk yesterday and I get the same thing (even when making new folders).

@TacticalTechJay
Copy link
Collaborator

Do the folders have a valid date when checking with the database? If you're using postgres with docker, you can use this:
docker compose exec postgres psql -U postgres -d postgres -c "SELECT * FROM \"Folder\";"

@TacticalTechJay
Copy link
Collaborator

Alternatively, you can use the API to check the date. You can either use curl with your token in the header or use the browser you're logged into zipline on. The endpoint is /api/user/folders

@wraithy
Copy link
Author

wraithy commented May 25, 2023

Alternatively, you can use the API to check the date. You can either use curl with your token in the header or use the browser you're logged into zipline on. The endpoint is /api/user/folders

Looks like they do have valid dates when checking the database.

image

EDIT: Actually I think the issue is that they are not whole seconds and have a decimal at the end which is resulting in it being an invalid date.

@TacticalTechJay
Copy link
Collaborator

Hmmm, it could be. How is /api/user/folders? Does it show the right date?

@wraithy
Copy link
Author

wraithy commented May 25, 2023

Hmmm, it could be. How is /api/user/folders? Does it show the right date?

Dates look good to me via the endpoint

image

@wraithy
Copy link
Author

wraithy commented May 25, 2023

I also tried removing the decimal and the numbers after in the database however they are just set to 0 when I fetch the info from the API.

image

@TacticalTechJay
Copy link
Collaborator

Honestly got no clue what's causing this 😔
What browser @wraithdotcat? And is the issue still happening

@wraithy
Copy link
Author

wraithy commented Jul 22, 2023

Honestly got no clue what's causing this 😔 What browser @wraithdotcat? And is the issue still happening

I am using Chrome and yea it is still happening :/

@TacticalTechJay
Copy link
Collaborator

What version?

@wraithy
Copy link
Author

wraithy commented Jul 22, 2023

Trunk although I am using my fork (which is exactly the same just without the video thumbnails)

@TacticalTechJay
Copy link
Collaborator

Chrome version?

@wraithy
Copy link
Author

wraithy commented Jul 22, 2023

Version 115.0.5790.102 (Official Build) (64-bit)

@TacticalTechJay
Copy link
Collaborator

Do you currently use any extensions like an adblocker?

@wraithy
Copy link
Author

wraithy commented Jul 23, 2023

I do however I have tried other browsers and running in incognito and I get the same result

@diced
Copy link
Owner

diced commented Jul 23, 2023

If you don't mind me asking, what country do you live in? If you are able to get the locale it could help us see if the problem is with your locale's way of parsing dates.

@wraithy
Copy link
Author

wraithy commented Jul 23, 2023

If you don't mind me asking, what country do you live in? If you are able to get the locale it could help us see if the problem is with your locale's way of parsing dates.

I live in the UK however my instance is hosted in Ashburn, Virginia in the US. I assume that the times are based on the server time rather than the client but I could be wrong so I thought I would include both.

@TacticalTechJay
Copy link
Collaborator

Seems like that was it. Doesn't seem to enjoy other format for time

@TacticalTechJay
Copy link
Collaborator

@diced 🫡

@TacticalTechJay TacticalTechJay linked a pull request Jul 26, 2023 that will close this issue
diced pushed a commit that referenced this issue Jul 26, 2023
* fix: Compression setting works with the right files

* chore: clean up a debug log

* chore: add debug for why not webhook'd

* fix: No more temp invite when registering.

* fix: Add an error catch so server doesn't crash.

* chore: miniscule cleanup

* fix: Don't double fix dates. It was already fixed once.
@diced
Copy link
Owner

diced commented Jul 26, 2023

hopefully the commit above fixes this issue for good, but i'll still leave this issue open until we hear back from @wraithdotcat

@diced diced reopened this Jul 26, 2023
@wraithy
Copy link
Author

wraithy commented Jul 27, 2023

The dates are fixed now thanks!

image

however now the images don't load :/

image

the image source is domain.tld/r/image.png?compress=false and when I go directly to that url I get the following

{"statusCode":500,"code":"ENOENT","error":"Internal Server Error","message":"ENOENT: no such file or directory, open './mimes.json'"}

@TacticalTechJay
Copy link
Collaborator

Doesn't seem to have been caused by me ¯\_(ツ)_/¯
@diced I think you managed to exclude mimes.json from the docker image somewhere down the line...

@TacticalTechJay
Copy link
Collaborator

So, with the issue at the beginning resolved I'll be closing this. Open a new one with your new problem for organization purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants