Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth betterments #240

Merged
merged 3 commits into from
Dec 7, 2022
Merged

oauth betterments #240

merged 3 commits into from
Dec 7, 2022

Conversation

TacticalTechJay
Copy link
Collaborator

  • fix: use oauth's user id instead of username
  • feat: add login only config for oauth

Can someone please try and break this

@TacticalTechJay
- fix: use oauth's user id instead of username
6afa917 
 - feat: add login only config for oauth
diced
diced reviewed Dec 7, 2022
View reviewed changes
src/lib/config/Config.ts Outdated Show resolved Hide resolved
src/lib/config/readConfig.ts Outdated Show resolved Hide resolved
src/lib/config/validateConfig.ts Outdated Show resolved Hide resolved
src/lib/config/validateConfig.ts Outdated Show resolved Hide resolved
src/lib/middleware/withOAuth.ts Outdated Show resolved Hide resolved
@diced diced merged commit ea1a0b7 into diced:trunk Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diced diced diced approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TacticalTechJay @diced