reduce method complexity

dickschoeller · Jun 24, 2017 · 3801f0b · 3801f0b
1 parent c950a55
commit 3801f0b
Showing 1 changed file with 15 additions and 5 deletions.
diff --git a/...rer/src/main/java/org/schoellerfamily/gedbrowser/renderer/SubmittorNameIndexRenderer.java b/...rer/src/main/java/org/schoellerfamily/gedbrowser/renderer/SubmittorNameIndexRenderer.java
@@ -29,14 +29,24 @@ public String getIndexName() {
         if (!submittor.isSet()) {
             return "";
         }
-        final GedRenderer<? extends GedObject> renderer =
-                new SimpleNameRenderer(submittor.getName(),
-                        submittorRenderer.getRendererFactory(),
-                        submittorRenderer.getRenderingContext());
-        final String nameHtml = renderer.getNameHtml();
+        final String nameHtml = getNameHtml(submittor);
 
         return "<a class=\"name\" href=\"submittor?db=" + submittor.getDbName()
                 + "&amp;id=" + submittor.getString() + "\">" + nameHtml + " ["
                 + submittor.getString() + "]" + "</a>";
     }
+
+    /**
+     * Handle the messy getting of the name ready for HTML formatting.
+     *
+     * @param submittor the submittor whose name we are doing
+     * @return the string
+     */
+    private String getNameHtml(final Submittor submittor) {
+        final GedRenderer<? extends GedObject> renderer =
+                new SimpleNameRenderer(submittor.getName(),
+                        submittorRenderer.getRendererFactory(),
+                        submittorRenderer.getRenderingContext());
+        return renderer.getNameHtml();
+    }
 }