Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a LinkCreator class #759

Closed
dickschoeller opened this issue Jul 6, 2018 · 1 comment
Closed

Create a LinkCreator class #759

dickschoeller opened this issue Jul 6, 2018 · 1 comment
Assignees
@dickschoeller
Labels
code smell
Milestone
1.3.0-M5

Comments

@dickschoeller
Copy link
Owner

Create a LinkCreator class to be a base class for SourceCreator and SubmitterCreator (and SubmissionCreator eventually).

  • It will take a lot of the utility methods that are duplicated.
  • Can we pass in the service? That would allow to take others
  • Do need to check all places where SourceCreator and SubmitterCreator are sub-classed.
@dickschoeller dickschoeller added this to the 1.3.0-M5 milestone Jul 6, 2018
@dickschoeller dickschoeller self-assigned this Jul 6, 2018
@dickschoeller
Copy link
Owner Author

This should resolve the following Codebeat issues:

dickschoeller added a commit that referenced this issue Jul 6, 2018
@dickschoeller
Create new class to manage common source/submitter behavior
184dca7 
Fixes #759
@dickschoeller dickschoeller mentioned this issue Jul 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dickschoeller dickschoeller

Labels
code smell
Projects
None yet
Milestone
1.3.0-M5
Development

No branches or pull requests
1 participant
@dickschoeller