Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes on multiple converters #176

Merged
merged 4 commits into from
Feb 1, 2025
Merged

Small fixes on multiple converters #176

merged 4 commits into from
Feb 1, 2025
+14 −7

Conversation

dickwolff
Copy link
Owner

@dickwolff dickwolff commented Feb 1, 2025 •
edited
Loading

Fixes

  • 🐛 Bitvavo: unit price not parsed as a number
  • 🐛 DEGIRO V2: Unit price must be a number
  • 🏗️ Made checks around automatic import better, so informational logs are shown instead of errors

Checklist

  • Added relevant changes to README (if applicable)
  • Added relevant test(s)
  • Updated GitVersion file and corresponding version in package.json

Related issue (if applicable)

Fixes #175

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
src 100% 100% 0 ✔
src.converters 97% 90% 0 ✔
src.helpers 100% 100% 0 ✔
Summary 97% (1593 / 1636) 90% (855 / 945) 0 ✔

@dickwolff dickwolff merged commit 1733ac7 into main Feb 1, 2025
4 checks passed
@dickwolff dickwolff deleted the feat/Converter-fixes branch February 1, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitvavo: JSON import throws error
1 participant
@dickwolff