Tighten matching by orderId in case of an empty order ID #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making the changes. I will hopefully have time this afternoon to update the tests so it can be merged. |
|
Unfortuntately I can't edit your branch. As the tests still succeed on your branch, I will go ahead and merge this and then add the tests on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Checklist
package.jsonRelated issue (if applicable)
Description
This is based on my research of what I found in;
#173 (reply in thread)
#173 (reply in thread)
I did try to add testing for it, but I couldn't figure out the Yahoo Service Mocking service and how it expected data to be added to it 😅.