Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tenant ecosystem management #201

Merged
merged 17 commits into from
Mar 1, 2022
Merged

feat: tenant ecosystem management #201

merged 17 commits into from
Mar 1, 2022

Conversation

TimoGlastra
Copy link
Collaborator

@TimoGlastra TimoGlastra commented Feb 22, 2022 •
edited
Loading

Fixes #176

Fixes #157

Fixes #186

Fixes #176

Fixes #185

@TimoGlastra
fix: better exception handling
2bd2ed5 
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
refactor: error handling, wallet endpoints refactor
46c1e83 
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
test: fix connection tests
5260ab8 
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
style: fix codacy issues
1b08dc9 
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
temp
60fdf6f 
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
tenant api with tests
c6a4ea8 
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
revert to local ledger
0a5cddc 
Signed-off-by: Timo Glastra <[email protected]>
This was linked to issues Feb 22, 2022
Ecosystem management #99
Closed
[cloud-api] integrate trust registry and ecosystem into tenant api #157
Closed
@TimoGlastra TimoGlastra removed a link to an issue Feb 22, 2022
Ecosystem management #99
Closed
10 tasks
@TimoGlastra TimoGlastra marked this pull request as ready for review February 27, 2022 20:44
morrieinmaas
morrieinmaas reviewed Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@morrieinmaas morrieinmaas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few knitpicks and questions, but great job🙌🚀. That was a beast of PR

app/admin/tenants/onboarding.py Show resolved Hide resolved
app/admin/tenants/onboarding.py Show resolved Hide resolved
app/admin/tenants/onboarding.py Show resolved Hide resolved
app/admin/tenants/onboarding.py Outdated Show resolved Hide resolved
app/admin/tenants/models.py Show resolved Hide resolved
app/facades/trust_registry.py Show resolved Hide resolved
app/facades/webhooks.py Show resolved Hide resolved
app/tests/conftest.py Show resolved Hide resolved
app/tests/util/client.py Show resolved Hide resolved
app/tests/verifier/test_verifier_utils.py Show resolved Hide resolved
@TimoGlastra
chore: resolve feedback
5e95f84 
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
Copy link
Collaborator Author

Ok addressed your feedback. Please let me know if you see anything else that needs changing :)

@morrieinmaas
Copy link
Collaborator

LGTM and thanks for all the explanations

@TimoGlastra TimoGlastra merged commit b4fa267 into development Mar 1, 2022
@TimoGlastra TimoGlastra deleted the feature/tenants branch March 1, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrieinmaas morrieinmaas morrieinmaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TimoGlastra @morrieinmaas