-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the runtime dependency #23
Comments
I don't see much gain in removing the runtime dependency only for cases without custom comparers, to me this is either all or nothing -- either we move all comparers to be source generated and get rid of the runtime dependency at all or we don't. It's a sizeable piece of work. |
The main problem is that the Runtime package has a dependency: <PackageReference Include="Microsoft.Bcl.HashCode" Version="1.1.0" /> |
This has been removed from 3.0 as it caused issues in packages with InternalsVisibleTo. Needs to rethink the approach. |
Could this be fixed by users needing it referencing |
I haven't had any time to look into it since. I think users referencing the Runtime explicitly is a worse experience overall. Ideally we should be able to drop the Runtime library completely. There's a branch for it, but it needs rebasing and some extra work. |
Another idea is to remove the runtime dependency, especially for those who don't use custom Comparers. They can be delivered explicitly (with
global::
full typepaths to avoid possible collisions).Originally posted by @HavenDV in #22 (comment)
The text was updated successfully, but these errors were encountered: