Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the need for Generator.Equals.Runtime #48

Merged
merged 2 commits into from
Jan 8, 2023
Merged

Conversation

diegofrata
Copy link
Owner

It also updates dependencies to use C# 9 and incremental source generators.

Fixes #23.

@diegofrata diegofrata merged commit cec7581 into develop Jan 8, 2023
@ssttgg
Copy link
Collaborator

ssttgg commented Jan 9, 2023

Great work!

@diegofrata
Copy link
Owner Author

Happy new year! Would you like to give the last beta a go?

It all works relatively well until you start adding InternalsVisibleTo and try to use Equatable in the lib you have granted visibility to. Then you get warnings about C# not knowing which definitions to use. It is quite a niche scenario, but I don't know if it's solvable.

@ssttgg
Copy link
Collaborator

ssttgg commented Jan 9, 2023

I've updated to the beta build on my project, I'll try it out and bear the issue you mentioned in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants