Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[language] Added byte string literal support. b"" #4058

Closed
wants to merge 1 commit into from
Closed

[language] Added byte string literal support. b"" #4058

wants to merge 1 commit into from

Conversation

RIg410
Copy link
Contributor

@RIg410 RIg410 commented May 26, 2020

Motivation

Added byte string literal support. b""

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Unit test.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@review-assign-bot review-assign-bot bot requested a review from kphfb May 26, 2020 21:07
@MIRAI-bot
Copy link

A wild Move coverage report has appeared!

New coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Signer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 98.78
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 14.94
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 84.38
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SlidingNonce
>>> % Module coverage: 85.31
+-------------------------+
| % Move Coverage: 97.11  |
+-------------------------+
Baseline coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
+-------------------------+
| % Move Coverage: 99.14  |
+-------------------------+

If these two differ, you should look at updating the baseline, or adding more tests.

You can get more details here

@sblackshear sblackshear requested review from bob-wilson, tnowacki and vgao1996 and removed request for kphfb May 26, 2020 22:56
tnowacki
tnowacki reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@tnowacki tnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Mostly some style comments, and we will need some additional tests especially on the runtime side of things

language/move-lang/src/parser/lexer.rs Outdated Show resolved Hide resolved
language/move-lang/tests/move_check/parser/byte_string.move Outdated Show resolved Hide resolved
@RIg410 RIg410 force-pushed the feature_byte_string branch from 669d77e to 4b4a214 Compare May 27, 2020 15:46
@MIRAI-bot
Copy link

A wild Move coverage report has appeared!

New coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Signer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 98.78
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 14.94
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 84.38
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SlidingNonce
>>> % Module coverage: 85.31
+-------------------------+
| % Move Coverage: 97.11  |
+-------------------------+
Baseline coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
+-------------------------+
| % Move Coverage: 99.14  |
+-------------------------+

If these two differ, you should look at updating the baseline, or adding more tests.

You can get more details here

@MIRAI-bot
Copy link

A wild Move coverage report has appeared!

New coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Signer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 98.78
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 14.94
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 84.38
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SlidingNonce
>>> % Module coverage: 85.31
+-------------------------+
| % Move Coverage: 97.11  |
+-------------------------+
Baseline coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
+-------------------------+
| % Move Coverage: 99.14  |
+-------------------------+

If these two differ, you should look at updating the baseline, or adding more tests.

You can get more details here

@RIg410 RIg410 force-pushed the feature_byte_string branch 2 times, most recently from 4e04779 to 752c965 Compare May 27, 2020 21:31
@MIRAI-bot
Copy link

A wild Move coverage report has appeared!

New coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Signer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 98.78
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 14.94
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 84.38
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SlidingNonce
>>> % Module coverage: 85.31
+-------------------------+
| % Move Coverage: 97.11  |
+-------------------------+
Baseline coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
+-------------------------+
| % Move Coverage: 99.14  |
+-------------------------+

If these two differ, you should look at updating the baseline, or adding more tests.

You can get more details here

@MIRAI-bot
Copy link

A wild Move coverage report has appeared!

New coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Signer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 98.78
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 14.94
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 84.38
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SlidingNonce
>>> % Module coverage: 85.31
+-------------------------+
| % Move Coverage: 97.11  |
+-------------------------+
Baseline coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
+-------------------------+
| % Move Coverage: 99.14  |
+-------------------------+

If these two differ, you should look at updating the baseline, or adding more tests.

You can get more details here

bob-wilson
bob-wilson suggested changes May 27, 2020
View reviewed changes
language/move-lang/src/parser/lexer.rs Outdated Show resolved Hide resolved
language/move-lang/src/parser/syntax.rs Outdated Show resolved Hide resolved
language/move-lang/src/parser/syntax.rs Outdated Show resolved Hide resolved
language/move-lang/tests/move_check/parser/byte_string_success.move Outdated Show resolved Hide resolved
language/move-lang/src/parser/byte_string.rs Outdated Show resolved Hide resolved
language/move-lang/src/parser/byte_string.rs Outdated Show resolved Hide resolved
language/move-lang/src/parser/byte_string.rs Outdated Show resolved Hide resolved
language/move-lang/tests/move_check/parser/byte_string_invalid_escaped_sequence.exp Outdated Show resolved Hide resolved
language/move-lang/tests/move_check/parser/byte_string_invalid_hex.exp Outdated Show resolved Hide resolved
language/move-lang/tests/move_check/parser/byte_string_invalid_unicode.exp Outdated Show resolved Hide resolved
@RIg410 RIg410 force-pushed the feature_byte_string branch from 752c965 to 86eaee7 Compare May 28, 2020 14:31
@MIRAI-bot
Copy link

A wild Move coverage report has appeared!

New coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Signer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 98.78
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 14.94
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 84.38
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SlidingNonce
>>> % Module coverage: 85.31
+-------------------------+
| % Move Coverage: 97.11  |
+-------------------------+
Baseline coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
+-------------------------+
| % Move Coverage: 99.14  |
+-------------------------+

If these two differ, you should look at updating the baseline, or adding more tests.

You can get more details here

@RIg410 RIg410 force-pushed the feature_byte_string branch from 86eaee7 to f9ab9bb Compare May 28, 2020 17:19
@MIRAI-bot
Copy link

A wild Move coverage report has appeared!

New coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Signer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 98.78
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 14.94
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 84.38
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SlidingNonce
>>> % Module coverage: 85.31
+-------------------------+
| % Move Coverage: 97.11  |
+-------------------------+
Baseline coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
+-------------------------+
| % Move Coverage: 99.14  |
+-------------------------+

If these two differ, you should look at updating the baseline, or adding more tests.

You can get more details here

@bors-libra
Copy link
Contributor

☔ The latest upstream changes (presumably cf22ca2) made this pull request unmergeable. Please resolve the merge conflicts.

tnowacki
tnowacki reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@tnowacki tnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, its really starting to shape up! I made some comments about style (particularly in language/move-lang/src/parser/byte_string.rs).
But these aren't critical to getting the PR in.

I would focus on the test cases first and foremost. Then we can get in this great contribution! After it lands, I might take a pass to make the decoding logic fit more inline with the style used in the rest of the project.

language/move-lang/src/parser/byte_string.rs
filename: &'static str,
start_offset: usize,
buffer: Vec<u8>,
escape_sequence: Option<Sequence>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this escape sequence field? I feel like we can just make a loop to eat the sequence in between the braces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will make it harder to handle the hex sequence. And it might make it harder to add other sequences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how it will make it harder to do the hex sequence? I'm envisioning a separate loop for just the hex case, where it starts and stops at the { and } respectively

I don't see any other cases being added. And if they are, I don't see this solution being better than just a separate function or loop for that case

language/move-lang/src/parser/byte_string.rs Outdated Show resolved Hide resolved
language/move-lang/src/parser/byte_string.rs Outdated Show resolved Hide resolved
language/move-lang/src/parser/lexer.rs Outdated Show resolved Hide resolved
language/move-lang/src/parser/byte_string.rs Outdated Show resolved Hide resolved
@RIg410 RIg410 force-pushed the feature_byte_string branch from f9ab9bb to 98499ff Compare May 29, 2020 08:11
@MIRAI-bot
Copy link

A wild Move coverage report has appeared!

New coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 70.13
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 17.33
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 98.70
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 96.46
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 64.84
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 98.30
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.99
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SlidingNonce
>>> % Module coverage: 85.31
+-------------------------+
| % Move Coverage: 91.34  |
+-------------------------+
Baseline coverage report 
+-------------------------+
| Move Coverage Summary   |
+-------------------------+
Module 00000000000000000000000000000000::Debug
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Testnet
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraTimestamp
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Association
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountLimits
>>> % Module coverage: 96.87
Module 00000000000000000000000000000000::Vector
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Empty
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountType
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::VASP
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Unhosted
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::AccountTrack
>>> % Module coverage: 88.96
Module 00000000000000000000000000000000::LCS
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Hash
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::Authenticator
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Offer
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Event
>>> % Module coverage: 92.25
Module 00000000000000000000000000000000::LibraConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::RegisteredCurrencies
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::FixedPoint32
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Libra
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin1
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Coin2
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Compare
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Option
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Signature
>>> % Module coverage: NaN
Module 00000000000000000000000000000000::LibraTransactionTimeout
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraAccount
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::ValidatorConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraSystem
>>> % Module coverage: 98.98
Module 00000000000000000000000000000000::TransactionFee
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraWriteSetManager
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraBlock
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LBR
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::Genesis
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVMConfig
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::LibraVersion
>>> % Module coverage: 100.00
Module 00000000000000000000000000000000::SharedEd25519PublicKey
>>> % Module coverage: 100.00
+-------------------------+
| % Move Coverage: 99.14  |
+-------------------------+

If these two differ, you should look at updating the baseline, or adding more tests.

You can get more details here

@bob-wilson bob-wilson self-requested a review May 29, 2020 17:32
@bob-wilson
Copy link
Contributor

Sorry to be slow to respond here. I had a packed schedule of meetings yesterday. I've caught up on the discussion here, and I'm pretty happy with the current PR. I see Todd had one or two comments still, so I'll leave it to him to approve.

tnowacki
tnowacki approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@tnowacki tnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good! As I mentioned before, I might make some changes to this after it lands, but the overall logic looks good.

Thanks for the contribution!

@tnowacki
Copy link
Contributor

tnowacki commented Jun 1, 2020

@bors-libra r=tnowacki

@bors-libra
Copy link
Contributor

📌 Commit 98499ff has been approved by tnowacki

@bors-libra
Copy link
Contributor

⌛ Testing commit 98499ff with merge 174d96d...

@github-actions
Copy link

github-actions bot commented Jun 1, 2020

Cluster Test Result

all up : 1297 TPS, 3484 ms latency, no expired txns

Repro cmd:

./scripts/cti --tag land_174d96d9 --run bench

@bors-libra
Copy link
Contributor

☀️ Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: tnowacki
Pushing 174d96d to master...

@bors-libra bors-libra closed this in 174d96d Jun 1, 2020
@RIg410 RIg410 deleted the feature_byte_string branch August 5, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnowacki tnowacki tnowacki approved these changes

@vgao1996 vgao1996 Awaiting requested review from vgao1996

@bob-wilson bob-wilson Awaiting requested review from bob-wilson

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RIg410 @MIRAI-bot @bors-libra @bob-wilson @tnowacki