Fix/remove mem uninitialized #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
force-pushed
the
fix/remove_mem_uninitialized
branch
from
3328cbd to
6cc5f0d
Compare
JohnTitor
reviewed
Aug 6, 2019
| @@ -76,7 +76,7 @@ impl<DB: TypeMetadata> Output<'static, Vec<u8>, DB> { | |||
| /// Unsafe to use for testing types which perform dynamic metadata lookup. | |||
| pub fn test() -> Self { | |||
| use std::mem; | |||
| #[allow(clippy::invalid_ref)] | |||
| #[allow(clippy::invalid_ref, deprecated)] | |||
There was a problem hiding this comment.
The alternative for the line below would be Self::new(Vec::new(), unsafe { mem::MaybeUninit::uninit().assume_init() }) which would basically be also UB.
Therefore I think it is not worth changing it.
(cc @diesel-rs/core just in case)
There was a problem hiding this comment.
Ah okay, I got it. Could we add a comment about it?
There was a problem hiding this comment.
A comment for what exactly? There is already a comment describing what this function tries to achieve.
There was a problem hiding this comment.
I mean it's reasonable to leave a comment on why we use the deprecated method, what about?
JohnTitor
approved these changes
Aug 7, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2117
Closes #2089
Closes #2136