Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides Eclipse 4.10 JDT #368

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Conversation

alvinmeimoun
Copy link
Contributor

I didn't created this PR from an issue, but i needed to locally test spotless with JDT 4.10.
So at the same time i created this PR to provides and set Eclipse 4.10 JDT by default

I followed the same changes as this PR : Provides Eclipse 4.9 JDT

@alvinmeimoun alvinmeimoun marked this pull request as ready for review March 7, 2019 15:07
@alvinmeimoun alvinmeimoun changed the title Eclipse jdt 4.10.0 Provides Eclipse 4.10 JST Mar 7, 2019
@alvinmeimoun alvinmeimoun changed the title Provides Eclipse 4.10 JST Provides Eclipse 4.10 JDT Mar 7, 2019
@nedtwigg
Copy link
Member

nedtwigg commented Mar 7, 2019

Thanks very much @alvinmeimoun, this looks great. Will have this released by Monday.

@nedtwigg nedtwigg requested a review from fvgh March 7, 2019 17:35
Copy link
Member

@fvgh fvgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nedtwigg nedtwigg merged commit 9f346e9 into diffplug:master Mar 7, 2019
@nedtwigg
Copy link
Member

Released in 3.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants