feat: Add SyncController [2/2] #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypercore manages peers on a "per-hypercore" basis, e.g. each hypercore has a unique set of peers. However for Mapeo we need to treat all hypercores belonging to a peer as one, so we need to combine the peer core sync states across all cores, and then have a means for a particular peer to control which cores / namespaces are replicated to the replication stream. This abstraction is for managing the enabling of namespaces with a particular peer, and will be managed by the sync controller. This replaces functionality that is currently in the CoreManager and the ReplicationStateMachine that is currently returned by coreManager.replicate().
* feat/peer-sync-controller: WIP: fix up tests and start addressing bugs
* feat/peer-sync-controller: fix types fix bug fix PeerSyncController tests
* feat/peer-sync-controller: allow peer sync controller without peerId
2 tasks
achou11
approved these changes
Oct 25, 2023
|
Yes good point it should be yes |
This was referenced Nov 16, 2023
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sync controller implements the
replicate()method, manages sync state, and peer sync controller instances.This PR is missing tests, but given the complexity of setting up unit tests to invite peers and add data, I think the time is better spent actually implementing and integrating that on the API, so that we can go straight to an e2e test.