Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin more hyper deps #381

Merged
merged 4 commits into from
Nov 17, 2023
Merged

chore: pin more hyper deps #381

merged 4 commits into from
Nov 17, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Nov 16, 2023 •
edited
Loading

Tomas was dealing with issues because of a mangled lockfile, which updated a transitive dep (hyperblobs) and caused issues in our tests.

This change won't fix that scenario, but just to avoid other potential headaches in the future, pinning any hyper deps that haven't been pinned yet.

@achou11 achou11 requested a review from gmaclennan November 16, 2023 20:10
gmaclennan
gmaclennan approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe add hyperblobs as a dep too in order to pin it? And try to include this in the release to avoid issues

@achou11 achou11 force-pushed the ac/pin-more-hyper-deps branch from 5d82eb5 to e702291 Compare November 17, 2023 14:44
@achou11 achou11 merged commit 526d257 into main Nov 17, 2023
7 checks passed
@achou11 achou11 deleted the ac/pin-more-hyper-deps branch November 17, 2023 14:54
@optic-release-automation optic-release-automation bot mentioned this pull request Nov 17, 2023
Merged
gmaclennan added a commit that referenced this pull request Nov 20, 2023
@gmaclennan
Merge branch 'main' into feat/initial-download
ca60188 
* main:
  chore: pin more hyper deps (#381)
  chore: extract and test construction of icon url (#366)
  chore: fix release workflow configuration (#379)
  chore: remove unused/unneeded deps (#376)
  chore: remove authstore (#377)
  fix: handle duplicate connections to LocalPeers (#378)
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 4, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 12, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 14, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 30, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 9, 2024
Merged
This was referenced Jun 20, 2024
Merged
Merged
Merged
This was referenced Jul 25, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 13, 2024
Merged
This was referenced Aug 21, 2024
Merged
Merged
This was referenced Aug 29, 2024
Merged
Merged
Merged
Merged
This was referenced Sep 2, 2024
Merged
Merged
This was referenced Sep 11, 2024
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achou11 @gmaclennan