feat: dbMigrationPathOpt - add db migration path to MapeoProject and MapeoManager
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add optional opt for projectMigrationFolder to mapeoProject with default value * add optional opt for projectMigrationFolder and clientMigrationFolder to mapeoManager with default values Since I put a default value to both params I made both of them optionals, but maybe it not the right approach? Also the types for both are strings and then turned into a path with `new URL`
achou11
requested changes
Nov 21, 2023
There was a problem hiding this comment.
I don't think the options should be optional with a default value, as it assumes the location of the migrations directory, which is what we're trying to avoid with this change. Will need to update/fix the tests to account for the suggested changes.
Also suggested changing migration to migrations (plural) to be consistent with the option name from drizzle
Co-authored-by: Andrew Chou <[email protected]>
Co-authored-by: Andrew Chou <[email protected]>
Co-authored-by: Andrew Chou <[email protected]>
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #341
For now:
Since I put a default value to both params I made both of them optionals, but maybe it not the right approach?
Also the types for both are strings and then turned into a path with
new URL