chore: use Map, not Record, for listing all roles
#512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should have no user impact. I generally prefer `Map`s to `Record`s when the keys are variable. This is mainly due to bugs with keys like `hasOwnProperty` or `__proto__`, but they also allow non-string keys. As far as I could tell, we were always using `Map`s in relevant spots except for `Roles.prototype.getAll()`...but no longer!
gmaclennan
approved these changes
Mar 11, 2024
gmaclennan
approved these changes
Mar 11, 2024
Co-Authored-By: Gregor MacLennan <[email protected]>
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should have no user impact, and is not urgent.
I generally prefer
Maps toRecords when the keys are variable. This is mainly due to bugs with keys likehasOwnPropertyor__proto__, but they also allow non-string keys.As far as I could tell, we were always using
Maps in relevant spots except forRoles.prototype.getAll()...but no longer!