chore: Update @mapeo/schema, fix breaking changes related to Icon #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasciccola
changed the title
tomasciccola
commented
Apr 10, 2024
added 3 commits
April 11, 2024 13:46
tomasciccola
commented
Apr 15, 2024
tomasciccola
commented
Apr 15, 2024
tomasciccola
commented
Apr 15, 2024
|
mmhm, still need to fix some type errors on the icon unit tests |
EvanHahn
approved these changes
Apr 15, 2024
Co-authored-by: Evan Hahn <[email protected]>
EvanHahn
approved these changes
Apr 16, 2024
src/fastify-plugins/icons.js
Outdated
| value | ||
| ) | ||
| ) { | ||
| if (!VALID_PIXEL_DENSITIES.includes(value)) { |
There was a problem hiding this comment.
I would fix this error by casting value to any.
Suggested change
| if (!VALID_PIXEL_DENSITIES.includes(value)) { | |
| if (!VALID_PIXEL_DENSITIES.includes(/** @type {any} */ (value))) { |
There was a problem hiding this comment.
mhmh, I also needed to change the signature of the fn to /** @param {any} value */
|
@EvanHahn for this to be merged we need a new version of mapeo-schema published. It makes sense that that happens after adding tracks. After that I'll remove the locally built mapeo-schema comitted here and then we can merge |
* feat: add track data type * Add e2e CRUD tests for tracks --------- Co-authored-by: Gregor MacLennan <[email protected]>
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #547 . This PR basically covers breaking changes on mapeo-schema brought by this (basically removing
pixelDensityfromIcons whosemimeTypeis"image/svg+xml")Before merging, a new version of @mapeo/schema should be published, and the tar.gz on this branch should be removed