chore: invites should use special invite ID, not project public key #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
approved these changes
Jun 11, 2024
| * @param {Readonly<Buffer>} projectKey | ||
| * @returns {Buffer} | ||
| */ | ||
| export function projectKeyToProjectInviteId(projectKey) { |
There was a problem hiding this comment.
I think this belongs in @mapeo/crypto, so that we can version it separately. We can move it in a follow-up PR.
There was a problem hiding this comment.
Done in digidem/mapeo-crypto#26.
EvanHahn
added a commit
to digidem/mapeo-crypto
that referenced
this pull request
Jun 11, 2024
Similar to `keyToPublicId`, this adds a `keyToInviteId` for deriving an invite ID. This was originally added in `@mapeo/core` but should live here instead. See <digidem/comapeo-core#571>.
EvanHahn
added a commit
to digidem/mapeo-crypto
that referenced
this pull request
Jun 26, 2024
Similar to `keyToPublicId`, this adds a `keyToInviteId` for deriving an invite ID. This was originally added in `@mapeo/core` but should live here instead. See <digidem/comapeo-core#571>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sophisticated bad actor who knows a project's public ID could spam invites to determine whether someone was in a project.
Now, they need the harder-to-get "project invite ID", which is a separate generated value.
Closes #559.