Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix type errors in NamespaceSyncState tests #593

Merged
merged 1 commit into from
Apr 30, 2024
Merged

chore: fix type errors in NamespaceSyncState tests #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/sync/namespace-sync-state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,13 @@ test('sync cores in a namespace', async function (t) {
for (const key of cm1Keys) {
if (key.equals(writer1.core.key)) continue
const core = cm1.getCoreByKey(key)
core.download({ start: 0, end: -1 })
core?.download({ start: 0, end: -1 })
}

for (const key of cm2Keys) {
if (key.equals(writer2.core.key)) continue
const core = cm2.getCoreByKey(key)
core.download({ start: 0, end: -1 })
core?.download({ start: 0, end: -1 })
}
})

Expand Down Expand Up @@ -190,12 +190,12 @@ test('replicate with updating data', async function (t) {
for (const key of cm1Keys) {
if (key.equals(writer1.core.key)) continue
const core = cm1.getCoreByKey(key)
core.download({ live: true, start: 0, end: -1 })
core?.download({ start: 0, end: -1 })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best I could tell, live was not used in Hypercore at all.

}

for (const key of cm2Keys) {
if (key.equals(writer2.core.key)) continue
const core = cm2.getCoreByKey(key)
core.download({ live: true, start: 0, end: -1 })
core?.download({ start: 0, end: -1 })
}
})
Loading