chore: test serving audio #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
approved these changes
May 21, 2024
There was a problem hiding this comment.
LGTM.
It seems like GitHub Actions are having issues...maybe we can wait to see if those resolve before merging?
There was a problem hiding this comment.
heh, its the whilhelm scream, a mytical audio sample that appears in A LOT of movies
…addAudioServeTest
Mhm, it seems that the fastify test is hanging and not related with the CI issues. Its hanging on the test after the one I've added ( |
|
I was forgetting to stop the fastify controller.. |
tomasciccola
had a problem deploying
to
github-pages
GitHub Actions
Failure
EvanHahn
approved these changes
May 22, 2024
…addAudioServeTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a test and an audio test file