fix: at startup, clean up left projects that failed to delete #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you start to leave a project and the operation fails partway, we now finish the next time you try to load that project. For example, imagine the following scenario: 1. The user presses the "leave project" button. 2. We mark them as having left the project, but haven't yet deleted any data. 3. Their phone runs out of battery. Previously, the project state would be messed up in this scenario. Now, we finish the cleanup before returning the project. Fixes [#583]. [#583]: #583
EvanHahn
commented
May 23, 2024
| (dataStore) => dataStore.namespace !== 'auth' | ||
| ) | ||
|
|
||
| await Promise.all(dataStoresToUnlink.map((ds) => ds.close())) |
There was a problem hiding this comment.
We need to close earlier in the process now, because of the following race condition:
- We open a project.
- We close the writer core (see line 636 below).
- We start indexing the writer core (via
MultiCoreIndexer). This fails because the writer core has been closed.
(This was theoretically a problem before. Someone could load a project and immediately leave it.)
EvanHahn
commented
May 23, 2024
achou11
approved these changes
May 29, 2024
| @@ -345,4 +347,51 @@ test('leaving a project while disconnected', async (t) => { | |||
| ) | |||
| }) | |||
|
|
|||
| test('partly-left projects are cleaned up on startup', async (t) => { | |||
There was a problem hiding this comment.
it'd be nice to confirm that data (on disk) is actually cleaned up in this scenario. not sure how complicated that would be to test though
There was a problem hiding this comment.
Opened #693 to test this. (Doesn't test this specific cleanup case; let me know if you want me to do that.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you start to leave a project and the operation fails partway, we now finish the next time you try to load that project.
For example, imagine the following scenario:
Previously, the project state would be messed up in this scenario. Now, we finish the cleanup before returning the project.
Fixes #583.