chore: don't error when calling #sendHaves without a peer
#691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were effectively doing something like this:
```javascript
if (!object) {
console.warn('no object', object.propertyAccessThatWillFail)
}
```
This could throw an error because we can't access properties on `null`
or `undefined`.[^0]
This updates the log message to avoid this error.
[^0]: It's possible that the value was another falsy value, such as
`false`, where you can technically access properties. I still think this
change is an improvement in that situation, because
`false.remotePublicKey` is `undefined`, which isn't very useful.
EvanHahn
deleted the
improve-error-handling-when-calling-sendhaves-without-peer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were effectively doing something like this:
This could throw an error because we can't access properties on
nullorundefined.1This updates the log message to avoid this error.
Footnotes
It's possible that the value was another falsy value, such as
false, where you can technically access properties. I still think this change is an improvement in that situation, becausefalse.remotePublicKeyisundefined, which isn't very useful. ↩