Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: invites #70

Merged
merged 6 commits into from
Feb 28, 2023
Merged

feat: invites #70

merged 6 commits into from
Feb 28, 2023

Conversation

gmaclennan
Copy link
Member

@gmaclennan gmaclennan commented Feb 7, 2023

Support project invites over an RPC channel that can be muxed on the same stream as hypercore replication.

Implemented as an RPC class, allowing future support of other communication over RPC as needed (e.g. for app updates)

In a follow-up PR: Add additional properties to the invite (e.g. project name) as needed by designs

@gmaclennan gmaclennan changed the base branch from main to mapeo-core-store February 7, 2023 22:49
@gmaclennan gmaclennan changed the title feat: invites [WIP] feat: invites Feb 8, 2023
@gmaclennan gmaclennan marked this pull request as ready for review February 8, 2023 21:07
@sethvincent sethvincent changed the base branch from mapeo-core-store to main February 8, 2023 22:02
@gmaclennan
Copy link
Member Author

Rebased on main

Copy link
Contributor

@sethvincent sethvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! After looking through it again I still don't have any specific concerns. It'll be best to merge this and make issues for anything that comes up during integration with other modules.

@gmaclennan gmaclennan merged commit b95bfbf into main Feb 28, 2023
gmaclennan added a commit that referenced this pull request Mar 1, 2023
@gmaclennan gmaclennan deleted the feat/invites branch August 31, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants