feat: detect closed connections with TCP keepalive #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If two peers connect and one disconnects, the other won't necessarily know. 1. Alex and Charlie connect. Alex sees that they are connected to 1 device. 2. Charlie disconnects from wifi. Alex still sees a connection to 1 device, even though the connection should be broken. We can fix this in several ways. I think the best is to enable [TCP keepalive], which effectively sends a packet every second asking, "is this connection still on?". I did not add unit tests for this (I could not think of a good way) but did test manually in CoMapeo with two Android devices. [TCP keepalive]: https://tldp.org/HOWTO/TCP-Keepalive-HOWTO/overview.html
gmaclennan
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two peers connect and one disconnects, the other won't necessarily know.
We can fix this in several ways. I think the best is to enable TCP keepalive, which effectively sends a packet every second asking, "is this connection still on?".
I did not add unit tests for this (I could not think of a good way) but did test manually in CoMapeo with two Android devices.