feat!: update @mapeo/schema to latest version
#715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - Removes `createdBy` from documents. Removes `MapeoProject.prototype.$createdByToDeviceId` as a side-effect. - Returns `originalVersionId` on all documents. Closes <#371>. Depends on <https://github.com/digidem/mapeo-schema/pull/191> and <digidem/mapeo-mock-data#7>.
EvanHahn
commented
Jul 10, 2024
gmaclennan
requested changes
Jul 11, 2024
|
I think this is finally ready for another review. A lot of (unrelated) stuff was required to update |
EvanHahn
added a commit
that referenced
this pull request
Aug 26, 2024
Our tests have several spots where we create mock data, such as observations or presets. We typically rely on `@mapeo/mock-data` for this, but could use it in a few more places. That's what this commit does! I think this is useful for three reasons: 1. It's less code. 2. It doesn't need to be manually updated when we make schema updates. 3. It will make [an upcoming change][0] smaller. [0]: #715
EvanHahn
changed the title
createdBy with originalVersionId@mapeo/schema to latest version
EvanHahn
added a commit
that referenced
this pull request
Aug 26, 2024
Our tests have several spots where we create mock data, such as observations or presets. We typically rely on `@mapeo/mock-data` for this, but could use it in a few more places. That's what this commit does! I think this is useful for three reasons: 1. It's less code. 2. It doesn't need to be manually updated when we make schema updates. 3. It will make [an upcoming change][0] smaller. [0]: #715
|
I'm going to merge this because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
Removes
createdByfrom documents. RemovesMapeoProject.prototype.$createdByToDeviceIdas a side-effect.Returns
originalVersionIdon all documents.Updates
@mapeo/schemato the latest version, which requires a bunch of other changes.Closes #371. Depends on https://github.com/digidem/mapeo-schema/pull/191 and digidem/mapeo-mock-data#7.
Co-Authored-By: Tomás Ciccola [email protected]