-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Integrate @mapeo/schema update #741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
* now `iconApi.create` returns the full doc * generate tables
tomasciccola
changed the title
Chore: fix after @mapeo/schema update
Chore: Integrate @mapeo/schema update
Aug 1, 2024
tomasciccola
changed the title
Chore: Integrate @mapeo/schema update
chore: Integrate @mapeo/schema update
Aug 5, 2024
Add `docRefversionId` to query filters when present
gmaclennan
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating mapeo/schema to next.18 various changes need to be integrated. Roughly:
refs
have been removed (see https://github.com/digidem/mapeo-schema/pull/196)For now this changes the
IconApi
, where.create
returns the entire doc (mimickingdataType.create
) instead of only thedocId
, and translationApi, where nowdocIdRef
isdocRef.docId
(and, for nowdocRef.versionId
is optional