chore: use Object.hasOwn()
#749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should have no user impact.
`Object.hasOwn()` replaces `Object.prototype.hasOwnProperty()` in modern
JavaScript. Its advantages can be seen in the following code snippet:
```
// Still works even if you overwrite `hasOwnProperty`:
const overwritten = { hasOwnProperty: () => true }
Object.hasOwn(overwritten, "foo")
// => false
overwritten.hasOwnProperty("foo")
// => true (incorrect)
// Still works even if the object has a null prototype:
const nullPrototype = Object.create(null)
nullPrototype.foo = "bar"
Object.hasOwn(nullPrototype, "foo")
// => true
nullPrototype.hasOwnProperty("foo")
// TypeError: nullPrototype.hasOwnProperty is not a function
```
This replaces all uses of `Object.prototype.hasOwnProperty()` with
`Object.hasOwn()`.
I think this is a useful change on its own, but will also help in a
future change.
EvanHahn
commented
Aug 14, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "es2019", | |||
| "lib": ["es2020"], | |||
| "lib": ["es2022"], | |||
There was a problem hiding this comment.
Object.hasOwn works in our version of Node, so I believe this is a safe change to make.
tomasciccola
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should have no user impact.
Object.hasOwn()replacesObject.prototype.hasOwnProperty()in modern JavaScript. Its advantages can be seen in the following code snippet:This replaces all uses of
Object.prototype.hasOwnProperty()withObject.hasOwn().I think this is a useful change on its own, but will also help in a future change.