chore: allow null in several Protomux method options
#763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a types-only change. Several Protomux methods support `null` IDs ([`pair`, for example][0]). This updates our type definitions to reflect that. I think this is a useful change on its own, but may make upcoming changes easier too. [0]: https://github.com/holepunchto/protomux/blob/50b98c93580002a7e32fb12eefe07493fc2a3ade/index.js#L371
EvanHahn
requested review from
gmaclennan and
achou11
and removed request for
gmaclennan
achou11
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a types-only change.
Several Protomux methods support
nullIDs (pair, for example). This updates our type definitions to reflect that.I think this is a useful change on its own, but may make upcoming changes easier too.