chore: move PRESYNC_NAMESPACES into central constants file #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
force-pushed
the
move-presync-namespaces-to-constants
branch
from
11baacd to
49d432c
Compare
This change should have no impact. The `PRESYNC_NAMESPACES` array is pretty central, but was stuffed away in `sync/peer-sync-controller.js`; that doesn't quite feel like where it belongs. Now it's in a more central spot: `constants.js`. I think this is useful on its own, but it should make a future change easier.
EvanHahn
force-pushed
the
move-presync-namespaces-to-constants
branch
from
49d432c to
46bbaff
Compare
achou11
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should have no impact.
The
PRESYNC_NAMESPACESarray is pretty central, but was stuffed away insync/peer-sync-controller.js; that doesn't quite feel like where it belongs.Now it's in a more central spot:
constants.js.I think this is useful on its own, but it should make a future change easier.