fix: respect all data namespaces for sync auto-stop #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
commented
Aug 26, 2024
Comment on lines
+16
to
+19
| /** @type {ReadonlyArray<Namespace>} */ | ||
| export const DATA_NAMESPACES = NAMESPACES.filter( | ||
| (namespace) => !PRESYNC_NAMESPACES.includes(namespace) | ||
| ) |
There was a problem hiding this comment.
This was removed recently in 2b36edd, and I'm adding it back same as it was.
EvanHahn
force-pushed
the
restart-autostop-timeout-for-blobs
branch
from
c71891f to
6b25f57
Compare
EvanHahn
commented
Aug 28, 2024
| @@ -333,13 +346,25 @@ test('auto-stop', async (t) => { | |||
|
|
|||
| await clock.tickAsync(9000) | |||
|
|
|||
| const observation2 = await invitorProject.observation.create( | |||
There was a problem hiding this comment.
Pseudocode for this diff:
-createObservation()
+createBlob()
checkThatAutostopTimeoutIsUpdated()
gmaclennan
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reset the auto-stop timer if we receive any new data since our last sync update. However, we were only respecting the
datanamespace and forgot about theblobnamespace.This fixes that.
Closes #768.