Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: uninstall unused light-my-request dependency #774

Merged
merged 1 commit into from
Aug 26, 2024
Merged

chore: uninstall unused light-my-request dependency #774

merged 1 commit into from
Aug 26, 2024

Conversation

EvanHahn
Copy link
Contributor

This dependency seems unused, so we can remove it.

It looks like it was added in 8e64abd but never used.

@EvanHahn
chore: uninstall unused light-my-request dependency
73e7735 
This dependency seems unused, so we can remove it.

It looks like it was added in 8e64abd
but never used.
achou11
achou11 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used transitively by fastify but fastify specifies it as a prod dep anyways, so unless we need it pinned to a specific version, this changes seems reasonable

@EvanHahn EvanHahn merged commit 4631e65 into main Aug 26, 2024
7 checks passed
@EvanHahn EvanHahn deleted the uninstall-light-my-request branch August 26, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achou11 achou11 achou11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanHahn @achou11