Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use await instead of then in server route #878

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Oct 1, 2024

This is a minor change. I think it makes sense to use await in an async function, rather than using then to handle the promise.

(I guess we're awaiting in either case, but I think this is clearer.)

This is a minor change. I think it makes sense to use `await` in an
async function, rather than using `then` to handle the promise.

(I guess we're `await`ing in either case, but I think this is clearer.)
@EvanHahn EvanHahn requested a review from gmaclennan October 1, 2024 22:07
@EvanHahn EvanHahn merged commit 000c52c into server Oct 1, 2024
0 of 6 checks passed
@EvanHahn EvanHahn deleted the remove-promise-from-hasExistingProject branch October 1, 2024 22:34
EvanHahn added a commit that referenced this pull request Oct 1, 2024
This is a minor change. I think it makes sense to use `await` in an
async function, rather than using `then` to handle the promise.

(I guess we're `await`ing in either case, but I think this is clearer.)
EvanHahn added a commit that referenced this pull request Oct 3, 2024
This is a minor change. I think it makes sense to use `await` in an
async function, rather than using `then` to handle the promise.

(I guess we're `await`ing in either case, but I think this is clearer.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant