feat: media manager v1 #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)` (#940) - Removes `blobStore.download()` and the `LiveDownload` class. - Adds `blobStore.createEntriesReadableStream()` which is a stream of all entries in the blob store, filtered by blob type and variant(s). - Changes behaviour of `BlobStore` to auto-download blobs according to a `downloadFilter`. - Changes the `BlobStore` filter according to `isArchiveDevice` setting. - Changes the behaviour of `CoreManager` to not auto-download blob cores (this responsibility is now with `BlobStore`). Closes [#681]. [#681]: #681 Co-authored-by: Evan Hahn <[email protected]>
This is a types-only change. We were already importing the `BlobFilter` type above, so let's use it!
*You may wish to [review this squashed commit as separate commits][0].* When you receive a blob filter from another peer, this updates their sync states. For example, if you receive a blob filter that says "I only want photo thumbnails", that peer's "wants" bitfield will be reduced. Closes [#682] and [#905]. [0]: https://github.com/digidem/comapeo-core/pull/956/commits [#682]: #682 [#905]: #905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines #940, #957, and #956.
I plan to YOLO-merge this if CI passes.