fix: restore installation of @node-rs/crc32 optional deps #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Status | Previous | Current |
|---|---|---|---|
@emnapi/core |
- | 1.3.1 | |
@emnapi/runtime |
- | 1.3.1 | |
@emnapi/wasi-threads |
- | 1.0.1 | |
@napi-rs/wasm-runtime |
- | 0.2.6 | |
@node-rs/crc32-android-arm-eabi |
- | 1.10.6 | |
@node-rs/crc32-android-arm64 |
- | 1.10.6 | |
@node-rs/crc32-darwin-arm64 |
- | 1.10.6 | |
@node-rs/crc32-darwin-x64 |
- | 1.10.6 | |
@node-rs/crc32-freebsd-x64 |
- | 1.10.6 | |
@node-rs/crc32-linux-arm-gnueabihf |
- | 1.10.6 | |
@node-rs/crc32-linux-arm64-gnu |
- | 1.10.6 | |
@node-rs/crc32-linux-arm64-musl |
- | 1.10.6 | |
@node-rs/crc32-linux-x64-gnu |
1.10.3 | 1.10.6 | |
@node-rs/crc32-linux-x64-musl |
1.10.3 | 1.10.6 | |
@node-rs/crc32-wasm32-wasi |
- | 1.10.6 | |
@node-rs/crc32-win32-arm64-msvc |
- | 1.10.6 | |
@node-rs/crc32-win32-ia32-msvc |
- | 1.10.6 | |
@node-rs/crc32-win32-x64-msvc |
- | 1.10.6 | |
@node-rs/crc32 |
1.10.3 | 1.10.6 | |
@tybys/wasm-util |
- | 0.9.0 |
|
Ah, a hint! I've definitely tried the node_modules reinstallation approach, but that doesn't seem to work for me (given that the lockfile doesn't specify any of the binaries as deps) |
achou11
force-pushed
the
ac/restore-noders-crc32-optional-deps
branch
from
ce9b6d3 to
28a77aa
Compare
gmaclennan
approved these changes
Jan 22, 2025
yeah i don't want to run into something like this so my plan is to pack this branch and try this out locally for the mobile app before merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4f33bd0 updated the lockfile to remove the native binaries produced by
@node-rs/crc32, which prevents me from locally running anything that touchesyauzl-promise(which uses that module). This has happened in the past and I honestly don't really understand what the expected behavior should be or why this happens in general.The modules in question are marked as optional deps in the published package, but not sure how npm decides to add/remove these from the lockfile. And if they're considered optional, not sure why
@node-rs/crc32complains if the relevant binaries are missing at runtime (i.e. not truly optional by definition).Explicitly marking the module as a dependency for us seems to restore the lockfile so that the native binaries are included, but my guess is that this isn't the desired solution to the problem.