Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update comapeo-schema #985

Merged
merged 2 commits into from
Jan 22, 2025
Merged

chore: update comapeo-schema #985

merged 2 commits into from
Jan 22, 2025

Conversation

gmaclennan
Copy link
Member

this removes support for migration metadata for now

@gmaclennan gmaclennan self-assigned this Jan 22, 2025
@gmaclennan gmaclennan requested a review from achou11 January 22, 2025 18:06
@awana-lockfile-bot
Copy link

package-lock.json changes

Click to toggle table visibility
Name Status Previous Current
@comapeo/schema UPDATED 1.4.0 1.4.1

@gmaclennan gmaclennan marked this pull request as ready for review January 22, 2025 18:06
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this revert 2cc8555 as it introduced a database migration that we don't want to include?

@gmaclennan
Copy link
Member Author

Shouldn't this revert 2cc8555 as it introduced a database migration that we don't want to include?

Yes, thanks for catching that. I've updated the PR

@gmaclennan gmaclennan requested a review from achou11 January 22, 2025 19:49
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming tests pass

@gmaclennan gmaclennan merged commit c1d35a6 into main Jan 22, 2025
9 checks passed
@gmaclennan gmaclennan deleted the chore/update-schema branch January 22, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants