-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: translation #166
feat: translation #166
Conversation
wondering how to validate |
another nice to have would be to validate |
Another thing to address is how to solve a field ref for a field that is in an Array. i.e. |
this additionally adds the `is-language-code` dependency for validation
I went ahead and installed is-language-code which seems supported and up to date, but it uses smth called iana for language codes, which I don't know if we want to... |
I don't think we should validate when encoding / decoding. I think we should do that when writing. Invalid data will just be ignored, because lookups will just not work. If possible, we can add a type to I wrote up thoughts on language codes in the issue. For the fieldRef, I think we should just use a string, using dot-prop notation. This solves the question about field options (the example would be |
1. `fieldRef` is now a `string` 2. remove validation of fields when encoding 3. Add good-doc-completed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just missing the region code, plus some suggested copy edits. Otherwise good to merge I think.
Rename fields and change some descriptions from JSONSchema Co-authored-by: Gregor MacLennan <[email protected]>
…to feat/translation
should close #165