Store deleted documents in the kdb index. #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
reviewed
Feb 10, 2017
index.js
Outdated
| @@ -43,7 +43,8 @@ function DB (opts) { | |||
| if (v && v.lat !== undefined && v.lon !== undefined) { | |||
| next(null, { type: 'put', point: ptf(v) }) | |||
| } else if (d && Array.isArray(row.value.points)) { | |||
| next(null, { type: 'del', points: row.value.points.map(ptf) }) | |||
| var pt = row.value.points.map(ptf)[0] | |||
There was a problem hiding this comment.
We need an index record for each point in row.value.points. This property is set in the delete code and is an array of the lat/lon of each parent. Each of those records should be updated to point to the deleted record, i.e. we need two puts
There was a problem hiding this comment.
Yes, you are 100% right; good catch.
gmaclennan
reviewed
Feb 10, 2017
index.js
Outdated
| } else if (doc && doc.value && doc.value.d && doc.value.points) { | ||
| var pt = doc.value.points[0] | ||
| pt.deleted = true | ||
| addDoc(doc.value.d, link, pt) |
There was a problem hiding this comment.
I don't quite understand what this block is doing, can you explain?
There was a problem hiding this comment.
I'm marking deleted documents as such, but (below) filtering them out. This means no API changes or change in behaviour, but the new logic is in place. This is to make the breaking change PR smaller and a bit easier to reason about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for the larger goal of exposing deletions through the osm-p2p-db API.