DR2 2047 allow modification of max chars per cell #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparkhi
reviewed
Jan 29, 2025
| def getColumnFromCsv(csvFile: TextFile, csvSchemaFile: TextFile, columnName: String): List[String] = Try { | ||
| val validator = createValidator(true, Nil, false, false, false) | ||
| val csv = validator.loadCsvFile(csvFile, csvSchemaFile) | ||
| def getColumnFromCsv(csvFile: TextFile, csvSchemaFile: TextFile, columnName: String, maxCharsPerCell: Int): List[String] = Try { |
There was a problem hiding this comment.
Do we have to send the maxCharsPerCell to the validator as well as when calling a method on the validator?
If the validator knows about it, the method loadCsvFile can rely on using this.maxCharsPerCell
There was a problem hiding this comment.
Ah, yes! Good point. I think I was just trying to get it to work initially, and didn't go back to clean up.
sparkhi
reviewed
Jan 29, 2025
| } | ||
|
|
||
| private def validate(csvFile: String, csvEncoding: Charset, validateCsvEncoding: Boolean, csvSchemaFile: String, csvSchemaEncoding: Charset, validateCsvSchemaEncoding: Boolean, failFast: Boolean, pathSubstitutionsList: JList[Substitution], enforceCaseSensitivePathChecks: Boolean, trace: Boolean, progress: Option[SProgressCallback], skipFileChecks: Boolean): JList[FailMessage] = { | ||
| private def validate(csvFile: String, csvEncoding: Charset, validateCsvEncoding: Boolean, csvSchemaFile: String, csvSchemaEncoding: Charset, validateCsvSchemaEncoding: Boolean, failFast: Boolean, pathSubstitutionsList: JList[Substitution], enforceCaseSensitivePathChecks: Boolean, trace: Boolean, progress: Option[SProgressCallback], skipFileChecks: Boolean, maxCharsPerCellLimit: Int): JList[FailMessage] = { |
There was a problem hiding this comment.
Can we give the default value of 4096 here, so as to avoid the callers sending in 4096 as it looks like a magic number
sparkhi
reviewed
Jan 29, 2025
| toConsole("Error: Maximum number of errors to display should be more than 0") | ||
| 0 | ||
| } | ||
| val maxCharsPerCell = convertTextboxValueToInt(potentialMaxCharsPerCell, "errors to display", toConsole) |
There was a problem hiding this comment.
The error messages are swapped for textboxes
sparkhi
reviewed
Jan 29, 2025
techncl
force-pushed
the
DR2-2047_allowModificationOfMaxCharsPerCell
branch
from
27dba83 to
96ff697
Compare
techncl
force-pushed
the
DR2-2047_allowModificationOfMaxCharsPerCell
branch
3 times, most recently
from
dfc925c to
f5f44d9
Compare
techncl
force-pushed
the
DR2-2047_allowModificationOfMaxCharsPerCell
branch
from
f5f44d9 to
7ff37ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.