-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validator #15
base: main
Are you sure you want to change the base?
Add validator #15
Conversation
- Allow @context to be either a string or an array.
My main question about this PR is - why not use the |
was not aware that existed (I did look) so will look into that in a moment. EDIT: actually did see VeresOneDoc validator, but I guess it seemed out of date or to specific. |
@dmitrizagidulin looks like the validation there is: A. much more specific than this one: https://github.com/veres-one/did-veres-one/blob/master/lib/VeresOneDidDoc.js
honestly I think that validator is alright for veres, but definitely not general enough for all implementors of the spec. Perhaps we should run this validator on the document then do the rest of the existing VeresOneDidDoc validation? Others:
I guess the did identifier validation is good, but this seems more through or am I missing something? |
Can the existing VeresOneDid validator pass the tests here: I think it would throw a few false positives etc. p.s. thanks for reviewing this. |
This adds a validator for both Identifiers and Documents
that should conform to v0.13 of the DID Spec.
This is being used for the spec tests.