Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating and saving did:web DIDs. #43

Open
wants to merge 2 commits into
base: save
Choose a base branch
from

Conversation

dmitrizagidulin
Copy link
Contributor

No description provided.

@dmitrizagidulin dmitrizagidulin marked this pull request as ready for review March 30, 2022 17:37
@dlongley
Copy link
Member

Can we use a plugin-like architecture here instead? It seems unsustainable to keep adding every DID method we can think of to a monolithic package.

@dmitrizagidulin
Copy link
Contributor Author

@dlongley - I'm certainly open to suggestions, architecturally. In my experience, CLI tools tend to be fairly monolithic (unlike, say, isomorphic libs). And eventually, I assume we'd add support for the CLI tool using the Universal Verifier interface (which would provide support for a whole lot more methods).

Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to hold this up -- but I don't agree with the architectural choice of making it monolithic. Since I don't have any cycles to suggest or implement something else concrete I'm approving, but I expect it will create more technical debt to have to clean up later.

To be clear, it's certainly good to be able to make this work with did:web ... I'm just concerned about the how.

Thanks!

Supported DID methods:
- `did:key`
- [`did:web`](https://w3c-ccg.github.io/did-method-web/)
- Coming Soon: Veres One `did:v` (`capybara` testnet)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Coming Soon: Veres One `did:v` (`capybara` testnet)
- Coming Soon: Veres One `did:v1` (`capybara` testnet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants