Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to create a PBKDF2 hash with SHA-512 digest #370

Closed
wants to merge 1 commit into from

Conversation

stwiname
Copy link

No description provided.

@dlongley
Copy link
Member

@stwiname,

The SHA-512 module adds itself to forge.md, so that way you can leave it out of your project if you don't want to use it (see:

forge/js/sha512.js

Lines 17 to 22 in 2115c6d

var sha512 = forge.sha512 = forge.sha512 || {};
forge.md = forge.md || {};
forge.md.algorithms = forge.md.algorithms || {};
// SHA-512
forge.md.sha512 = forge.md.algorithms.sha512 = sha512;
). So I don't think we need that first change.

However, the additional tests are always welcome.

@stwiname
Copy link
Author

Is there something i need to do to initialize sha-512 then?

If I remove the changes to md.js then the added tests fail.

@davidlehn
Copy link
Member

sha512 support isn't added by default to the md module so that test will have to load it. Look at the code at the bottom of the file and update it to load sha512.

@felixSchl felixSchl force-pushed the pbkdf2-with-sha512 branch from 12291db to 2b724fa Compare June 1, 2016 00:59
@dlongley
Copy link
Member

Addressed by #456.

@dlongley dlongley closed this Jan 11, 2017
davidlehn added a commit that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants