2870: POI filters: Button to only show currently open locations can be cut off #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahaaTuffaha
requested review from
steffenkleinle,
ztefanie,
f1sh1918 and
LeandraH
as code owners
LeandraH
reviewed
Aug 13, 2024
release-notes/unreleased/2870-POI-filters-fix-toggle-button.yml
Outdated
Show resolved
Hide resolved
release-notes/unreleased/2870-POI-filters-fix-toggle-button.yml
Outdated
Show resolved
Hide resolved
LeandraH
approved these changes
Aug 14, 2024
steffenkleinle
approved these changes
Aug 17, 2024
…-only-show-currently-open-locations-can-be-cut-off
…-only-show-currently-open-locations-can-be-cut-off
|
By the way, you can enable auto-merge so that you don't have to come back to the PR to merge it when the pipeline is finished :) |
|
Code Climate has analyzed commit 83e54ca and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.9%. View more on Code Climate. |
bahaaTuffaha
deleted the
2870-POI-filters-Button-to-only-show-currently-open-locations-can-be-cut-off
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
The toggle button is cut off due to long sentences from languages like French.
Proposed changes
alignItems: 'center'to Row style just to make the text,icon and toggle aliened vertically on the same level.Side effects
None
Resolved issues
Fixes: #2870