2350: Show snackbar instead of opening settings #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
ztefanie,
f1sh1918 and
LeandraH
as code owners
steffenkleinle
commented
Oct 17, 2024
| @@ -41,7 +43,7 @@ export const requestPushNotificationPermission = async (): Promise<boolean> => { | |||
|
|
|||
| if (permissionStatus !== RESULTS.GRANTED) { | |||
| log(`Permission denied, disabling push notifications in settings.`) | |||
| await appSettings.setSettings({ allowPushNotifications: false }) | |||
| updateSettings({ allowPushNotifications: false }) | |||
There was a problem hiding this comment.
This led to unsynchronized settings.
|
Code Climate has analyzed commit 30ab681 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 55.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.3%. View more on Code Climate. |
LeandraH
approved these changes
Oct 21, 2024
ztefanie
reviewed
Nov 7, 2024
ztefanie
approved these changes
Nov 11, 2024
…ttings # Conflicts: # native/src/utils/createSettingsSections.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Explain that the settings have to be changed in order to enable push notifications if the permissions are denied.
Also fixes a bug that the push notifications are shown as enabled even if the permissions are denied.
Proposed changes
appContextsettingsSide effects
None.
Testing
onPress(can be tested by just throwing an error there)Resolved issues
Show snackbar instead of directly opening settings, refactor settings to
Fixes: #2350.