Fix php version #18
Merged
Fix php version #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the initial SDGClient available in the Digitalist namespace
The version shoudl be v1 instead of 1.0.0 and the leading / in the path caused guzzle to drop the v1 part, so remove that.
Ensure we form the URI correctly
…the API rejects the request otherwise
Some multiline strings in the YAML-file needed to be quoted or jane failed to parse them.
StatisticsInformation. The generated class just returns null regardless of what the API returns, which isn't great. This commit adds an override that returns the status and body. While we're adding overrides, might as well add one that strips of the leading slash from the URI, meaning we don't need to drop that manually after re-generation. Thus I'm also adding it back to the generated code.
…t-call-status Ensure we pass back helpful return values from calling StatisticsInformation.
If we're doing reporting for several sites, we might need different api keys in the same environment, so it's better to leave it up to the caller where to get the api key.
Set correct prod url
…istics-information Add method exposing the request body of StatisticsInformation requests.
Small note before open sourcing
* Prep composer file for packagist
…-update Update symfony/serializer 5.2.3 => 5.4.3
… info. Following issue queue for jane-php.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore to working version of sdg-php-client and add php version to composer config, test with php 8.0.18.