Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log snapshot responses #234

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Log snapshot responses #234

merged 1 commit into from
Dec 11, 2019

Conversation

timoreimann
Copy link
Contributor

This is to be consistent with how we log other gRPC responses as well.

Log snapshot responses
e39aaf0 
This is to be consistent with how we log other gRPC responses as well.
adamwg
adamwg approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@adamwg adamwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@timoreimann timoreimann merged commit 8008b09 into master Dec 11, 2019
@timoreimann timoreimann deleted the log-snapshot-responses branch December 11, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwg adamwg adamwg approved these changes

@waynr waynr Awaiting requested review from waynr

@varshavaradarajan varshavaradarajan Awaiting requested review from varshavaradarajan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timoreimann @adamwg