Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csi driver for k8s 1.26 #469

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Conversation

llDrLove
Copy link
Contributor

Followed the Prepare CSI driver for a new kubernetes minor version section for the 1.26 k8s release.

CLOSES: CON-8686

@llDrLove llDrLove self-assigned this Jan 10, 2023
@llDrLove llDrLove changed the title Update csi driver for k8s 1 26 Update csi driver for k8s 1.26 Jan 10, 2023
@llDrLove llDrLove marked this pull request as ready for review January 10, 2023 19:49
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Left one suggestion to clean up and one question.

@@ -15,6 +15,6 @@ jobs:
run: |
BRANCH=$(echo -n ${BRANCH} | tr -c '[:alnum:]._-' '-')
TOKEN=$(curl -s -H "Content-Type: application/json" -X POST -d '{"username": "'${DOCKER_USER}'", "password": "'${DOCKER_PASS}'"}' https://hub.docker.com/v2/users/login/ | jq -r .token)
images=("${BRANCH}-latest" "${BRANCH}-runtime" "${BRANCH}-tools" "${BRANCH}-tests-1.25" "${BRANCH}-tests-1.24" "${BRANCH}-tests-1.23" "${BRANCH}-tests-1.22" "${BRANCH}-builder")
images=("${BRANCH}-latest" "${BRANCH}-runtime" "${BRANCH}-tools" "${BRANCH}-tests-1.26" "${BRANCH}-tests-1.25" "${BRANCH}-tests-1.24" "${BRANCH}-tests-1.23" "${BRANCH}-tests-1.22" "${BRANCH}-builder")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably use the opportunity and get rid of 1.22; and while we're here remove 1.23 as well since it's already unsupported upstream, and DOKS will follow soonish.

(If this is not part of the documentation, could I ask you to add it, i.e., suggest to use the opportunity when we add support for a new version to also consider removing unsupported versions?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided out-of-band that this can be handled by a follow-up PR.

SupportedSizeRange:
Max: 100Gi
Min: 1Gi
Capabilities:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: have we validated that no new capabilities were added in the e2e test suite/framework that we may possibly support already?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovered together that upstream testing didn't support any new capabilities that our driver would support already. (This is becoming increasingly unlikely now that the upstream tests support all baseline features.)

@llDrLove llDrLove merged commit 898a721 into master Jan 11, 2023
@llDrLove llDrLove deleted the update-csi-driver-for-k8s-1-26 branch January 11, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants