-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce doctl auth init
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||
func (dsa *doitServerAuth) createAuthURL(ac *doitserver.AuthCredentials, kps ...keyPair) (string, error) { | ||
authURL, err := url.Parse(dsa.url) | ||
// RunAuthInit initializes the doctl config. Configuring is stored in $XDG_CONFIG_HOME/doctl. On Unix, if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Configuring/Configuration/
bryanl
force-pushed
the
auth-init
branch
6 times, most recently
from
July 25, 2016 02:59
88f9fe7
to
458f2ac
Compare
@aybabtme: ^^ |
var cfgFileWriter = defaultConfigFileWriter | ||
|
||
// ErrNoAccesToken is an error for when there is no access token. | ||
var ErrNoAccesToken = errors.New("no access token has been configured") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ErrNoAccesToken/ErrNoAccessToken/
at will |
add missing package statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
dolt auth init
command which replacesdolt auth login
.Instead of trying to fetch the token from the API, the user will have to manually enter it instead.
Also moves the default configuration location to
$XDG_CONFIG_HOME/doctl/doctlcfg
. On Windows, the default location is%APPDATA%/doctl/config
and on other platform without the environment variable set, it will look in$HOME/.config/doctl
.If the legacy location is detected, a warning will be displayed.
Fixes #59
Fixes #94