Ability to delete multiple snapshots and confirmation before delete #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixs #133
This is continued work on #139, which was closed because I pushed commits to it instead of another branch.
Ability to delete multiple snapshots
Problem with last PR was test units. At that time, I didn't know how to make test units and it was in TODO state.
This is not the case anymore, I learned more about
doctl&goand it's here. Test passes successfully, I hope test changes will not make another problem.Multiple delete has been tested, it is working flawless.
Beside that, confirmation like on droplets are added (incl.
forceflag). I don't know is it problem, or no, but I can revert it if it is not good place for it.