Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Firewalls create example with tags #1625

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

dbrian57
Copy link
Contributor

@dbrian57 dbrian57 commented Dec 5, 2024

Addresses user feedback about how to use tags when creating a firewall.

Updates firewalls create example with tags field.
Adds K8s tag example
@dbrian57 dbrian57 added the docs label Dec 5, 2024
@loosla
Copy link
Contributor

loosla commented Dec 6, 2024

Looks great! Thanks a lot for the update 🚀
Could you please also update L71 🙏 with

		tagNameRulesTxt := "A comma-separated list of existing tags, for example: frontend,backend,env:prod. Droplets with these tags will be placed behind the cloud firewall"

It may be useful to include an example with ":" to the --tag-names doc.
Many thanks.

Done in af3a106

@loosla loosla self-requested a review December 6, 2024 21:05
@loosla loosla self-assigned this Dec 6, 2024
@loosla loosla merged commit 8085263 into main Dec 9, 2024
8 checks passed
@loosla loosla deleted the docs/firewall-create-example branch December 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants