Add new Pki::issue method that takes an IssueOptions object #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires doc cleanup and tests |
kb
force-pushed
the
pki-issue-api-options
branch
from
14d8e6d to
aefb11b
Compare
To avoid a breaking api change, duplicated the existing Pki::issue method and updated it to take an IssueOptions object. This makes the api more flexible for future api option value additions and stacking many positional arguments into the method signature.
kb
force-pushed
the
pki-issue-api-options
branch
from
a447c56 to
aa72f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a breaking api change, duplicated the existing Pki::issue
method and updated it to take an IssueOptions object. This makes the
api more flexible for future api option value additions and stacking
many positional arguments into the method signature.